Skip to content

Upgrade to Scala.js 1.7.1. #13734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 20, 2021
Merged

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Oct 12, 2021

These changes can go in a patch release.

sjrd added 5 commits October 11, 2021 18:05
Now, everything goes through the extension methods in JSSymUtils.
Previously, we tested whether the default accessor itself had the
`@js.native` annotation. That is however never the case. Instead,
we now test whether the associated method has the annotation.

We still emit the *definitions* of those default accessors, even
though that they are never called anymore, because of backward
binary compatibility. If we stopped emitting them, a library
compiled with a newer Scala.js might not link anymore against an
application built with a previous Scala.js.

This is a forward port of
scala-js/scala-js@7e998b4
The default accessors matching that property are not emitted
anymore. This is similar to how default accessors for JS native
constructors are not emitted.

Unfortunately, for backward binary compatibility reasons, we must
still emit default accessors of JS native defs that are anything
else than `= js.native`. Until Scala.js 1.7.0, those default
accessors would actually be referenced by calling code (see
scala-js/scala-js#4554),
so removing them now would create dangling references.

This is a forward port of
scala-js/scala-js@e01dc1a
Nor for their default param accessors.

This is a forward port of
scala-js/scala-js@a95f3f6
@nicolasstucki nicolasstucki merged commit 8947f38 into scala:master Oct 20, 2021
@nicolasstucki nicolasstucki deleted the scalajs-1.7.1 branch October 20, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants